Skip to content

Integrate ArduinoCloudThing with ArduinoIoTCloud #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 179 commits into from
Jun 4, 2020

Conversation

aentinger
Copy link
Contributor

This resolves #125.

Gilberto Conti and others added 30 commits May 19, 2016 20:29
decode() needs to be rewritten
Fixed memory leak in CborArray, fixed ssize_t, #define CBOR_INT_T int
Accepts a pointer to the actual value
mirkokurt and others added 12 commits December 16, 2019 13:56
The volume setter function was incorrectly named setSwitch.
…obal timestamp. (#55)

This is necessary because right now we are relying on the RTC within the SAMD MCU which is instantiated (RTCZero) within the ArduinoIoTCloud library and reference within ArduinoCloudThing via extern devlaration. Due to the extern binding this is a very brittle dependency which can be easily destroyed, it is therefore better to explicitly register a function which provides the time (this can be serviced by the TimeService class available in ArduinoIoTCloud
…poch type timestamp

In arduino-libraries/ArduinoCloudThing#55 the possibility for retrieving a epoch type timestamp via a registered callback function has been introduced, the changes in #93 register such a function which allows us to to remove the hidden dependency to RTCZero altogether
…hat ArduinoCloudThing is no longer a stand-alone library but integrated with ArduinoIoTCloud
@aentinger aentinger self-assigned this Jun 3, 2020
@aentinger aentinger force-pushed the integrate-ArduinoCloudThing branch from ff14dd2 to 86a6544 Compare June 3, 2020 14:35
@arduino-libraries arduino-libraries deleted a comment from github-actions bot Jun 3, 2020
@arduino-libraries arduino-libraries deleted a comment from github-actions bot Jun 3, 2020
@arduino-libraries arduino-libraries deleted a comment from github-actions bot Jun 3, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2020

Codecov Report

Merging #129 into master will decrease coverage by 1.04%.
The diff coverage is 96.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #129      +/-   ##
==========================================
- Coverage   98.05%   97.01%   -1.05%     
==========================================
  Files           4       28      +24     
  Lines         103      972     +869     
==========================================
+ Hits          101      943     +842     
- Misses          2       29      +27     
Impacted Files Coverage Δ
src/cbor/ArduinoCloudProperty.cpp 93.61% <93.61%> (ø)
src/cbor/ArduinoCloudThing.cpp 94.98% <94.98%> (ø)
src/cbor/types/CloudColor.h 97.05% <97.05%> (ø)
src/cbor/ArduinoCloudProperty.h 100.00% <100.00%> (ø)
src/cbor/ArduinoCloudThing.h 100.00% <100.00%> (ø)
src/cbor/types/CloudBool.h 100.00% <100.00%> (ø)
src/cbor/types/CloudFloat.h 100.00% <100.00%> (ø)
src/cbor/types/CloudInt.h 100.00% <100.00%> (ø)
src/cbor/types/CloudLocation.h 100.00% <100.00%> (ø)
src/cbor/types/CloudString.h 100.00% <100.00%> (ø)
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6723e8...d47720f. Read the comment docs.

@aentinger aentinger force-pushed the integrate-ArduinoCloudThing branch from 86a6544 to caed2b6 Compare June 3, 2020 14:57
@arduino-libraries arduino-libraries deleted a comment from github-actions bot Jun 3, 2020
@github-actions
Copy link

github-actions bot commented Jun 3, 2020

Memory usage change @caed2b636a752cd6d9f988380f38a9e7a478392a

FQBN Flash Usage RAM For Global Variables
arduino:samd:mkr1000 N/A N/A
arduino:samd:mkrgsm1400 N/A N/A
arduino:samd:mkrnb1500 N/A N/A
arduino:samd:mkrwan1300 N/A N/A
arduino:samd:mkrwifi1010 N/A N/A
arduino:samd:nano_33_iot N/A N/A
esp8266:esp8266:huzzah N/A N/A

@aentinger aentinger merged commit 2d71ccf into master Jun 4, 2020
@aentinger aentinger deleted the integrate-ArduinoCloudThing branch June 4, 2020 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate ArduinoCloudThing with ArduinoIoTCloud
9 participants